https://go.dev/doc/go1.22#os/exec includes:
> On Windows, `Command` and `Cmd.Start` no longer call `LookPath` if the path to the executable is already absolute and has an executable file extension…
Thanks.
Please write this as CL 575055.
Maybe also 'For golang/go#66580.' so it's easier to see in the timeline of that issue it was reverted. Doesn't matter too much.
There's a problem affecting all Windows builders on LUCI, causing them fail with an error like:
```
Error: failed to run "go tool dist test -json": fork/exec C:\b\s\w\ir\cache\tools\bin\rdb: The …
We're investigating why recent Windows builds fail with an error that
involves the rdb command. Temporarily pin golangbuild to a known good
older version on one Windows builder to help that investiga…
Thanks.
I suspect tests won't be happy about this line being added. You can either remove it manually or `go install golang.org/x/tools/cmd/bundle@latest` and regen.
The change to http2/transport.go LGTM (in that it matches the upstream change which was reviewed).
The original CL 567175 made a change to http2/transport_test.go which is missing from this backport…
It's not submittable because one of the submit requirements is unsatisfied. Namely, the 'Matching-Subject-Prefix' submit requirement, which is intended to catch a mismatch between the actual target b…
(1 comment)
The Cq-Include-Trybots line is parsed as a git trailer only if it’s at the end of a commit message (i.e., in the last paragraph); it can’t be elsewhere. This blank line (line 29) is …
Hide additional duplicate builders to reduce noise and make progress
on the migration to LUCI.
This helped me notice that we haven't turned on linux-arm64-longtest
and linux-arm64-race in LUCI yet, …
> which would imply a builder with at least least Clang 15
There's a LUCI builder with clang 15 (e.g., [gotip-linux-amd64-clang15](https://ci.chromium.org/p/golang/builders/ci/gotip-linux-amd64-cl…
The linux/arm64 port is first class and has longtest and race builders
in the old infrastructure. We should have the capacity for it, so port
these builders to LUCI as well.
The PRPCClient variant is generated by a custom plugin and predates
the raw Client variant, which is preferred in newer code. Switch to
it before doing more to understand the previously-mentioned str…
Thanks. Note that even if you don't add a Google employee directly, once this CL has a +2 (from anyone) and a passing trybot result (not legacy), it'll show up in the https://go.dev/s/needs-review qu…
> you have to do [...] `DIR=$(mktemp -d); cd $DIR; go version`
If you'd like to determine the bundled Go toolchain's version, it's possible to do it with `GOTOOLCHAIN=local go version`. This is do…
It's new to the Go 1.23 release cycle and some races between the process landing and existing CLs being authored/tested earlier may happen, so it's okay. For more information on it, see https://group…
Un-resolving for visibility before auto-submit kicks in. Feel free to ack.
https://go.dev/wiki/CommitMessage#reverts suggests writing this as "CL 511516".
(1 comment)
This is no longer needed, right?
I sent you CL 571276 to remove it and CL 572777 to update relui to regenerate the new stdlib package every 6 months instead.
CL 567837 extracted the stdlib manifest from x/tools/internal/imports
to x/tools/internal/stdlib. That is the new package that will need to
be regenerated every 6 months after each major Go release.
…
This CL isn't directly causing the failures. It's happening in builders that are new and weren't meant to run in this repo. That was fixed in CL 571737, so restarting.
It's common for Go tests that require certain capability or dependency to skip themselves if the environment doesn't meet that requirement. For example, see the various `MustHave*` helpers in [`inter…
(5 comments)
Agree it's fine for those familiar with it to just run ./main.star, but I didn't think it'd be useful to mention it. You bring up a good point that we might get contributions from where…
The enabled function encodes a policy of which builders are supported.
For example, x/mobile is classified as PT.SPECIAL and has very few
builders enabled. x/build is classified as PT.TOOL and opts o…
Thanks for adding this.
Probably fine indeed, since x/build is not very high volume. If we run into a reason to back that out, maybe a way to do that is by using a "main.star" location filter.
Let's consider starting to do that in the new-to-be v3.4/glfw module (#393). What would some of the finer details look like? I wrote the following to try to answer that and explore options.
Its fi…
v3.3/glfw is its own module, separate from the top-level module that has the older versions v3.{0,1,2}/glfw. That seems to be working well, so I expect we can repeat that pattern and also have v3.4/g…
I can confirm the same program no longer panics now that GLFW 3.3.10 is pulled in. `glfw.GetKeyName(glfw.KeyUnknown, 0x003f)` returns an empty string. I think we can close this unless there's somethi…
(2 comments)
(nit) There's usually a single space between the `]` and the original CL subject.
As documented at https://go.dev/wiki/MinorReleases#making-cherry-pick-cls, please also update the orig…
Thanks.
As a side note, I'm starting to wonder if we should instead (or in addition) link to the upstream documentation on this at https://www.glfw.org/docs/latest/compile_guide.html#compile_deps_…
The comment of the DialConfig function was dropped during CL 463097.
There doesn't seem to be a good reason to do that, so bring it back.
For golang/go#57953.
This CL targets release-branch.go1.22, is that intentional?
If so, please see https://go.dev/wiki/MinorReleases for the process of backporting, which begins with creating backport issues.
This manual parameter might become obsolete in the future, in favor of
being pulled from another source automatically. Since that hasn't been
implemented yet, add a simple automated check to it in th…
This is done, and announced at https://groups.google.com/g/golang-dev/c/CqVVuxngzDU/m/MD4qrteuAQAJ.
There may be more to do in this general, but bulk of the work is done, so I'll close this. We ca…
(2 comments)
Go 1.22 and 1.21 by now, right? (gotip will be Go 1.23.)
These are the current darwin/amd64 builder types. They all tend to specify the macOS version, so "darwin-amd64" doesn't match a…
We're aware of some issues on the LUCI post-submit dashboard (https://ci.chromium.org/p/golang/g/go-gotip/console). This is an umbrella tracking issue to collect most critical ones that affect the Go…
(1 comment)
`goDebug` is added near `goExperiment` under a comment that says “Package-scoped variables that are initialized at the start of Test.”
However it’s not initialized to any value at…
Thanks for the fix.
I think a good approach is to use the -dry-run flag and run it locally.
For example, I ran it with `-dry-run -single-pr=golang/go#65218` flags as is, and it printed:
```
Proces…
Ok, that involves more steps, please see https://go.dev/wiki/MinorReleases.
Since this is the main tracking issue, let's move it to the Go1.23 milestone.
Thanks. Adding Cherry who reviewed the new packages and is in the proposed primary owner group (runtimeTeam) to review.
Is this the right import path? The packages added in CL 548695 and CL 548676 d…