dmitri.shuralyov.com/scratch/...

quine: add package quine dmitri.shuralyov.com/scratch#2

Mergedjbrandhorst.com opened this change 1 week ago
jbrandhorst.com commented 1 week ago

Quines are fun

Write Preview Markdown
dmitshur commented 1 week ago

They are. Although Go can make them too easy via go:embed.

See some initial comments.

Commit Message:7 (Patch Set 1) · 1 week ago

s/main/quine/ to match the path of the command being added.

Write Preview Markdown
quine/README.md:0 (Patch Set 1) · 1 week ago · edited

I suggest either adding a quine that can be licensed via the existing BSD-3-Clause LICENSE at the top level of the repo (see the "License" link at https://dmitri.shuralyov.com/scratch), or if you'd really rather stick with this command having a different license, then move it into a file named LICENSE in this directory. That way it will be recognized by this code host.

At that point the README.md is fairly empty. You can move its content to a package comment in quine.go doc.go, so that it too would be recognized and displayed at the future package page. Edit: I realize now that adding it to quine.go would interfere with its functionality hehe.

Write Preview Markdown
jbrandhorst.com uploaded Patch Set 2 1 week ago
dmitshur reviewed +2 1 week ago

LGTM. Thanks, and congrats on your first new Go package here!

Commit Message:7 (Patch Set 1) · 1 week ago

Done in PS 2.

Write Preview Markdown
quine/README.md:0 (Patch Set 1) · 1 week ago

Patch set 2 seems to resolve this.

Write Preview Markdown
dmitshur merged commit ed302c9ae10219a542d1a6d2d1293e1b7742b65a into main 1 week ago
Write Preview Markdown